Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed rotate_y property of particle shaders #46688

Merged
merged 1 commit into from
Apr 28, 2021

Conversation

QbieShay
Copy link
Contributor

@QbieShay QbieShay commented Mar 5, 2021

Sister PR of #46687

Closes #33357

@QbieShay QbieShay force-pushed the fix-particle-rotate-y-4 branch from bfc573c to f1bb54d Compare March 5, 2021 10:37
@akien-mga akien-mga added this to the 4.0 milestone Mar 5, 2021
@akien-mga akien-mga requested a review from a team March 5, 2021 10:39
@akien-mga akien-mga changed the title fixed particle rotate y flag Fixed rotate_y property of particle shaders Mar 5, 2021
@akien-mga akien-mga merged commit 7e0a42a into godotengine:master Apr 28, 2021
@akien-mga
Copy link
Member

Thanks!

@EzraT
Copy link

EzraT commented Apr 28, 2021

Thank you!

@Anyeos
Copy link

Anyeos commented Sep 6, 2024

Sorry but it is still present in 4.2.2-stable
I recently was trying to use CPUParticles3D to simulate a fall of branchs and all are facing the same angle regardless of angle_min or angle_max setting. But if I activate particle_flag_rotate_y it starts rotating with only setting the angle_min or angle_max (nothing more). It does not apply an initial rotation and stills there, it start to rotate like a pinwheel.

So, CPUParticles3D have the bug in Godot 4.2.2-stable
I tested GPUParticles3D and it does not happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3D particles initial angle with flag_rotate_y shows erratic behaviour
4 participants