Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors and crash with empty ConvexPolygonShape2D #46665

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

pouleyKetchoupp
Copy link
Contributor

Fixes crash mentioned in #45724 (comment), regression from #46291 and errors that were already present when trying to draw an invalid convex polygon.

@pouleyKetchoupp pouleyKetchoupp added bug topic:physics crash regression cherrypick:3.x Considered for cherry-picking into a future 3.x release topic:2d labels Mar 4, 2021
@pouleyKetchoupp pouleyKetchoupp added this to the 4.0 milestone Mar 4, 2021
@pouleyKetchoupp pouleyKetchoupp requested a review from a team March 4, 2021 16:49
@pouleyKetchoupp
Copy link
Contributor Author

@akien-mga This is important for the upcoming 3.2.4 RC, the editor currently crashes each time an empty ConvexPolygonShape2D is created.

@akien-mga akien-mga merged commit 6b25775 into godotengine:master Mar 4, 2021
@akien-mga
Copy link
Member

Thanks!

@pouleyKetchoupp pouleyKetchoupp deleted the fix-crash-convex-shape-2d branch March 4, 2021 19:35
@akien-mga
Copy link
Member

Cherry-picked for 3.2.4.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants