Input: Swap events for ui_redo to favor Shift+Ctrl+Z over Ctrl+Y #46316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That's the most common one we've been using for the general editor, and while the script editor also supports Ctrl+Y, it should have lower priority. In theory this code should make both be supported the same but for some reason the general editor only seems to use the first entry (the script editor does support both).
EricEzaM
approved these changes
Feb 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's the most common one we've been using for the general editor, and while the script editor
also supports Ctrl+Y, it should have lower priority.
In theory this code should make both be supported the same but for some reason the general editor
only seems to use the first entry (the script editor does support both).
That's a follow up to #43663 and a workaround, a better solution might be to fix what causes the main editor's undo redo not to match the second
InputEventKeyassigned toui_redo. We might still want to merge this to have Shift+Ctrl+Z as the first / favored action, which makes it appear in the contextual menu: