Fix physics queries not filtering out disabled collision shapes #45863
Conversation
pouleyKetchoupp
requested review from
AndreaCatania and
reduz
as code owners
This change allows collide_shape, intersect_shape, cast_motion and rest_info in both 2D and 3D to ignore disabled shapes and make them consistent with the physics simulation. In some other cases, _cull_aabb_for_body is used and filters shapes out internally, but whenever a physics query uses the broadphase directly without calling _cull_aabb_for_body, disabled shapes can be returned and need to be filtered out.
pouleyKetchoupp
force-pushed
the
physics-queries-disabled-shapes
branch
from
dd2822c to
50501f2
Compare
|
Thanks! |
|
@jitspoe - is this related to the problem you had on stream the other day? |
|
Sounds like it, Sslax. I tried to make a small repro test, but naturally couldn't reproduce it in that environment. I think it requires some sort of complex shapes interacting with each other. What I was trying to do was create a loop (something like in Sonic), so half of the loop had physics enabled, then after you touched the top of the loop, the other half would be enabled and the first half disabled. I did find a post mentioning it on the Godot forums, but I couldn't find a github issue. The workaround was to set the collision layers/mask instead of using the disabled flag. Edit: not the thread I was looking for, but maybe relevant: https://godotengine.org/qa/57186/disable-collisionshape2d-$collisionshape2d-disabled-godot |
This change allows
collide_shape,intersect_shape,cast_motionandrest_infoin both 2D and 3D to ignore disabled shapes and make them consistent with the physics simulation when testing for collision against the physics space.In some other cases,
_cull_aabb_for_bodyis used and filters shapes out internally, but whenever a physics query uses the broadphase directly without calling_cull_aabb_for_body, disabled shapes can be returned and need to be filtered out.It looks like there's no issue reported about this bug, so it's probably safer to fix it only on master for now as some users might rely on the current behavior in 3.2.