Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] Fix Rayshape not working properly in move_and_slide #45028

Closed
wants to merge 1 commit into from
Closed

[3.x] Fix Rayshape not working properly in move_and_slide #45028

wants to merge 1 commit into from

Conversation

pouleyKetchoupp
Copy link
Contributor

Adding a 3.2 version for PR #45005 because of space_sw renamed to space_3d_sw and collision_solver_sw renamed to collision_solver_3d_sw.

@pouleyKetchoupp
Fix Rayshape not working properly in move_and_slide
ed52bfd 
These changes improve Rayshape behavior for Godot Physics 2D and 3D
when using move_and_slide with and without snapping.

Kinematic margin is now applied to ray shapes when handling snapping
collision tests and separation raycasts to help getting consistent
results in slopes and flat surfaces.

Recovery is calculated without the margin and a depth of 0 is still
considered a collision to stabilize results when on flat surface.

Recovery is split based on the amount of shapes to fix cases where
multiple rayshapes would cause the body to bounce.

Fixes godotengine#34098
Fixes godotengine#34663
@pouleyKetchoupp pouleyKetchoupp added this to the 3.2 milestone Jan 8, 2021
@pouleyKetchoupp pouleyKetchoupp mentioned this pull request Jan 8, 2021
Closed
@pouleyKetchoupp pouleyKetchoupp requested a review from a team as a code owner March 12, 2021 12:26
Base automatically changed from 3.2 to 3.x March 16, 2021 11:11
@akien-mga akien-mga modified the milestones: 3.2, 3.3 Mar 17, 2021
@akien-mga akien-mga changed the title [3.2] Fix Rayshape not working properly in move_and_slide [3.3] Fix Rayshape not working properly in move_and_slide Mar 20, 2021
@akien-mga akien-mga modified the milestones: 3.3, 3.4 Mar 26, 2021
@akien-mga akien-mga changed the title [3.3] Fix Rayshape not working properly in move_and_slide [3.x] Fix Rayshape not working properly in move_and_slide Mar 26, 2021
@pouleyKetchoupp pouleyKetchoupp deleted the fix-rayshape-snap-3.2 branch October 6, 2021 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug topic:physics
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
2 participants
@pouleyKetchoupp @akien-mga