Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect format specifiers used to display some type data in the Visual Studio debugger #44757

Merged
merged 1 commit into from
Dec 28, 2020
Merged

Incorrect format specifiers used to display some type data in the Visual Studio debugger #44757

merged 1 commit into from
Dec 28, 2020

Conversation

KiritoAM
Copy link
Contributor

No description provided.

@akien-mga akien-mga added this to the 4.0 milestone Dec 28, 2020
@akien-mga
Copy link
Member

It doesn't necessarily need to be handled in this PR, but there are more issues with this .natvis file being outdated for the Godot 4.0 API (Pool*Array -> Packed*Array, etc.).

@KiritoAM
Copy link
Contributor Author

@akien-mga thanks for noticing that. I have fixed the issues relating to Variant, and am looking through to see if there are any other issues I can find. I can append to this pull request or create another one later. Unless someone tells me otherwise, I will add it to this pull request.

@pouleyKetchoupp
Copy link
Contributor

@andrew-softdev It's fine to add more to this PR. You can just amend your previous commit with the extra changes as described in https://docs.godotengine.org/en/stable/community/contributing/pr_workflow.html#modifying-a-pull-request

@KiritoAM KiritoAM changed the title Incorrect format specifiers used to display some String/StringName data in the Visual Studio debugger Incorrect format specifiers used to display some type data in the Visual Studio debugger Dec 28, 2020
pouleyKetchoupp
pouleyKetchoupp approved these changes Dec 28, 2020
View reviewed changes
Copy link
Contributor

@pouleyKetchoupp pouleyKetchoupp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine! Tested on VS 2019 v16.8.3.

@akien-mga akien-mga merged commit 8886a6a into godotengine:master Dec 28, 2020
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pouleyKetchoupp pouleyKetchoupp pouleyKetchoupp approved these changes

Assignees
No one assigned
Labels
bug platform:windows topic:buildsystem
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@KiritoAM @akien-mga @pouleyKetchoupp @YeldhamDev