Allow PluginScript to customize language's can_inherit_from_file attribute #44177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Dec 8, 2020
| @@ -78,7 +78,7 @@ class PluginScriptLanguage : public ScriptLanguage { | |||
| virtual Script *create_script() const; | |||
| virtual bool has_named_classes() const; | |||
| virtual bool supports_builtin_mode() const; | |||
| virtual bool can_inherit_from_file() { return true; } | |||
| virtual bool can_inherit_from_file(); | |||
There was a problem hiding this comment.
Should this be const like the other ones?
There was a problem hiding this comment.
Totally agree, however the parent method is not const:
Line 313 in d9f0477
I can provide another PR to fix this if you want ;-)
akien-mga
reviewed
Dec 8, 2020
| @@ -127,6 +127,7 @@ typedef struct { | |||
| const char **string_delimiters; // nullptr terminated array | |||
| godot_bool has_named_classes; | |||
| godot_bool supports_builtin_mode; | |||
| godot_bool can_inherit_from_file; | |||
There was a problem hiding this comment.
Is godot_bool value initialized automatically?
There was a problem hiding this comment.
nop, godot_bool is just and alias to a base type (defined as typedef bool godot_bool;)
In fact nothing is initialized automatically here given this .h is part of the gdnative C API (so this structure is created from C code, so everything must be explicitly initialized/teardown)
akien-mga
approved these changes
Dec 8, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
can_inherit_from_fileshould be customizable, not sure why it's not already the case ;-)This change break Pluginscript API so it shouldn't be cherry picked for 3.2