Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename CubeMesh to BoxMesh #44091

Merged
merged 1 commit into from
Dec 5, 2020
Merged

Rename CubeMesh to BoxMesh #44091

merged 1 commit into from
Dec 5, 2020

Conversation

madmiraal
Copy link
Contributor

Currently we have BoxShape and CSGBox, but CubeMesh. this PR renames CubeMesh to BoxMesh.
Part of #16863.

@madmiraal madmiraal added this to the 4.0 milestone Dec 4, 2020
@madmiraal madmiraal requested a review from a team as a code owner December 4, 2020 17:15
@madmiraal madmiraal changed the title Rename CubeMesh BoxMesh Rename CubeMesh to BoxMesh Dec 4, 2020
@akien-mga
Copy link
Member

Will need a rebase to fix Windows CI.

@madmiraal madmiraal force-pushed the rename-cubemesh-boxmesh branch from 13070a3 to df6b061 Compare December 5, 2020 11:48
@akien-mga akien-mga merged commit c574b4d into godotengine:master Dec 5, 2020
@akien-mga
Copy link
Member

Thanks!

@madmiraal madmiraal deleted the rename-cubemesh-boxmesh branch December 5, 2020 19:58
@madmiraal madmiraal mentioned this pull request Dec 8, 2020
Closed
83 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
breaks compat enhancement topic:core
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@madmiraal @akien-mga