Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Sync classref with current source #44080

Merged
merged 1 commit into from
Dec 4, 2020

Conversation

akien-mga
Copy link
Member

Needs review/amends, some of those changes might not be fully intended.

@akien-mga akien-mga requested a review from a team as a code owner December 4, 2020 10:08
@akien-mga akien-mga requested a review from reduz December 4, 2020 10:08
@akien-mga akien-mga added this to the 4.0 milestone Dec 4, 2020
doc/classes/ArrayMesh.xml Outdated Show resolved Hide resolved
Comment on lines 320 to 339
<constant name="ARRAY_FORMAT_CUSTOM_BASE" value="13" enum="ArrayFormat">
</constant>
<constant name="ARRAY_FORMAT_CUSTOM0_SHIFT" value="13" enum="ArrayFormat">
</constant>
<constant name="ARRAY_FORMAT_CUSTOM1_SHIFT" value="16" enum="ArrayFormat">
</constant>
<constant name="ARRAY_FORMAT_CUSTOM2_SHIFT" value="19" enum="ArrayFormat">
</constant>
<constant name="ARRAY_FORMAT_CUSTOM3_SHIFT" value="22" enum="ArrayFormat">
</constant>
<constant name="ARRAY_FORMAT_CUSTOM_MASK" value="7" enum="ArrayFormat">
</constant>
<constant name="ARRAY_COMPRESS_FLAGS_BASE" value="25" enum="ArrayFormat">
</constant>
<constant name="ARRAY_FLAG_USE_2D_VERTICES" value="33554432" enum="ArrayFormat">
</constant>
<constant name="ARRAY_FLAG_USE_DYNAMIC_UPDATE" value="67108864" enum="ArrayFormat">
</constant>
<constant name="ARRAY_FLAG_USE_8_BONE_WEIGHTS" value="134217728" enum="ArrayFormat">
</constant>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these values are pretty weird. Is that intended?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems intended. I'm not sure the _BASE variables are meant to be exposed though.

doc/classes/Control.xml Outdated Show resolved Hide resolved
doc/classes/SurfaceTool.xml Outdated Show resolved Hide resolved
doc/classes/SurfaceTool.xml Outdated Show resolved Hide resolved
@akien-mga akien-mga force-pushed the doc-sync branch 3 times, most recently from b3817f8 to 2d9b791 Compare December 4, 2020 14:56
@akien-mga akien-mga requested a review from JFonS as a code owner December 4, 2020 14:56
@akien-mga
Copy link
Member Author

Removed the redundant bindings in ArrayMesh (already in Mesh) as advised by @reduz.

And fixups:
- Add missing bindings in RenderingServer
- Remove duplicate ArrayMesh enum bindings (they're in Mesh already)
- Remove redundant _unhandled_key_input binding in Control (it's in Node
  already)
@aaronfranke
Copy link
Member

@akien-mga: Removed the redundant bindings in ArrayMesh (already in Mesh) as advised by @reduz.

See also #36382, specifically commit "Rebind Mesh/ArrayMesh enums" which removes the redundant bindings in ArrayMesh, but unlike here, it combines the docs by keeping the added detail currently present in the ArrayMesh docs.

@akien-mga
Copy link
Member Author

See also #36382, specifically commit "Rebind Mesh/ArrayMesh enums" which removes the redundant bindings in ArrayMesh, but unlike here, it combines the docs by keeping the added detail currently present in the ArrayMesh docs.

Seems good, though this commit also removes more duplicated enum bindings in ArrayMesh, and fixes the code examples accordingly. So if that's OK with you I'd propose to merge this PR and you can include the additional BlendShapeMode and documentation changes while rebasing #36382?

@akien-mga akien-mga merged commit 14660ee into godotengine:master Dec 4, 2020
@akien-mga akien-mga deleted the doc-sync branch December 4, 2020 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants