-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Sync classref with current source #44080
Conversation
doc/classes/ArrayMesh.xml
Outdated
<constant name="ARRAY_FORMAT_CUSTOM_BASE" value="13" enum="ArrayFormat"> | ||
</constant> | ||
<constant name="ARRAY_FORMAT_CUSTOM0_SHIFT" value="13" enum="ArrayFormat"> | ||
</constant> | ||
<constant name="ARRAY_FORMAT_CUSTOM1_SHIFT" value="16" enum="ArrayFormat"> | ||
</constant> | ||
<constant name="ARRAY_FORMAT_CUSTOM2_SHIFT" value="19" enum="ArrayFormat"> | ||
</constant> | ||
<constant name="ARRAY_FORMAT_CUSTOM3_SHIFT" value="22" enum="ArrayFormat"> | ||
</constant> | ||
<constant name="ARRAY_FORMAT_CUSTOM_MASK" value="7" enum="ArrayFormat"> | ||
</constant> | ||
<constant name="ARRAY_COMPRESS_FLAGS_BASE" value="25" enum="ArrayFormat"> | ||
</constant> | ||
<constant name="ARRAY_FLAG_USE_2D_VERTICES" value="33554432" enum="ArrayFormat"> | ||
</constant> | ||
<constant name="ARRAY_FLAG_USE_DYNAMIC_UPDATE" value="67108864" enum="ArrayFormat"> | ||
</constant> | ||
<constant name="ARRAY_FLAG_USE_8_BONE_WEIGHTS" value="134217728" enum="ArrayFormat"> | ||
</constant> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All these values are pretty weird. Is that intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems intended. I'm not sure the _BASE
variables are meant to be exposed though.
b3817f8
to
2d9b791
Compare
Removed the redundant bindings in |
And fixups: - Add missing bindings in RenderingServer - Remove duplicate ArrayMesh enum bindings (they're in Mesh already) - Remove redundant _unhandled_key_input binding in Control (it's in Node already)
See also #36382, specifically commit "Rebind Mesh/ArrayMesh enums" which removes the redundant bindings in |
Seems good, though this commit also removes more duplicated enum bindings in ArrayMesh, and fixes the code examples accordingly. So if that's OK with you I'd propose to merge this PR and you can include the additional BlendShapeMode and documentation changes while rebasing #36382? |
Needs review/amends, some of those changes might not be fully intended.