Fix : jpgd.cpp Added Additional check to half_image_x_size and half_image_y_size so that it's values wont be Negative[-1].

[Bhu1-V]

as u can see this was the image in MRP which was successfully imported and u can also see the size of the image is 1 x 1.
also tested with other 1x1 jpg images working just fine. I made changes only on H2V2ConvertFiltered() Function Since the problem was see there only. But i will try to Replicate the problem with different sampling and see whether any more changes are needed. FIX : #42363

[Bhu1-V]

Just Found out that i need to check value of

godot/thirdparty/jpeg-compressor/jpgd.cpp

Line 1672 in 30b6db9

const int half_image_x_size = (m_image_x_size >> 1) - 1;

in Function H1V2ConvertFiltered() and aslo value of

godot/thirdparty/jpeg-compressor/jpgd.cpp

Line 1765 in 30b6db9

const int half_image_y_size = (m_image_y_size >> 1) - 1;

H2V1ConvertFiltered() , to be non - negative to not crash.

[Bhu1-V]

After the last Commit we can fully use 1 x 1 pixel jpg images of any sub-sampling without Engine crash.

EVIDENCE 💯
here are some jpg images of different sub-sampling imported into Engine.
H1V1 : 👍

H1V2 : 👍

H2V1 : 👍

H2V2 : 👍

TESTED - PROJECT :
gdtest.zip

[akien-mga]

The fix looks fine, but there are a few changes that should be made before it's merged:

• Commits should be squashed into one, see PR workflow.
• The commit message for the resulting commit should be amended to be clearer about what the commit does. "Update filename" is not a good message as it doesn't say what the update does. See CONTRIBUTING.md for tips on writing good commit messages.
• The four changed lines use inconsistent style and parentheses, they should be fixed to all be exactly the same. There's no reason for them to differ.

Finally, this is a thirdparty library so it would be best if we can get this patch merged upstream, so that all users of this library can benefit from the fix. This can also lead to writing a better fix with feedback from the original author of this code.

Could you make a PR to https://github.com/richgel999/jpeg-compressor with those fixes?

We can still merge our own fix in Godot in the meantime, as historically https://github.com/richgel999/jpeg-compressor development was virtually stopped until a recent surge of bugfixing activity - I don't know if Rich is still around reviewing further PRs or if this will happen in another batch in a year or more.

[akien-mga]

Superseded by #43441.