-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android: Allow Mouse Capture #43249
Android: Allow Mouse Capture #43249
Conversation
99a26f6
to
6ad41e3
Compare
@thebestnom For my own education, what does mouse capture allow you to accomplish? |
Mouse capture in android term is the ability to make the mouse relative and not based on location and hide the cursor (for fps style controls for example) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One feedback, otherwise it looks good code wise.
After rebasing to master it stopped working, Im testing to see why |
@m4gr3d Ok, I found a bug on gdscript interpreter on android (or something of that kind) you can see here the code, on windows it works as intended, but you can see in the code image what happnes... that so weird trying to make minimal code to repreduce that |
e9887c3
to
ce103c1
Compare
This is looking like this is working, after 3 branch and cursor shape (that I'm already have working) Ill try to repreduce the bug minimaly Also custom shape from native to java is hard |
ce103c1
to
b31d746
Compare
That's very strange! @vnen Any idea what may be happening here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I've added some cleanup and code health feedback, and it should be good for approval once they're resolved.
b31d746
to
021572f
Compare
Fixed review 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor feedback but looks good overall!
021572f
to
e7f259c
Compare
Thanks! |
@m4gr3d Oh no, I missed a horrible mistake, opening a new PR now |
Allow mouse capture in android
Tested with https://github.com/thebestnom/Android-Tester
Im not 100% sure about where to with capture, currently I just clicked the last place before the capture (you can see that when the button will be continue to click even after the capture in the test app)
I'll cherrypick to 3.2 once the PR is approved