Increase the default HTTPClient download chunk size to 64 KiB #42896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
cherrypick:3.x
Faless
approved these changes
Nov 7, 2020
This improves download speeds at the cost of increased memory usage. This change also effects HTTPRequest automatically. See godotengine#32807 and godotengine#33862.
Calinou
force-pushed
the
httprequest-increase-chunk-size
branch
from
2b2204e to
1335709
Compare
Calinou
changed the title
|
Thanks! |
|
Cherry-picked for 3.2.4. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves download speeds at the cost of increased memory usage.
This change also effects HTTPRequest automatically.
Since this doesn't break backwards compatibility, I marked this as cherry-pickable.
See #32807 and #33862.