Added default value for uniforms in visual shaders #40754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chaosus
force-pushed
the
vs_default_uniforms
branch
from
c394e11 to
8fefdcf
Compare
akien-mga
reviewed
Jul 28, 2020
| @@ -1486,6 +1486,8 @@ class VisualShaderNodeFloatUniform : public VisualShaderNodeUniform { | |||
| float hint_range_min; | |||
| float hint_range_max; | |||
| float hint_range_step; | |||
| bool default_value_enabled; | |||
There was a problem hiding this comment.
This should likely be done in a separate PR, but we now initialize member variables directly in their declaration in the header, instead of deferring it to the constructor.
So you could refactor all VisualShaderNodes to move all those initializations to the header.
akien-mga
approved these changes
Jul 28, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added possibility to the setup a default value for Float,Int,Boolean,Color,Vector and Transform uniforms.
Closes godotengine/godot-proposals#807