Stopped canvas/spatial editor from becoming active when clicking a node in the scene tree if script editor is currently active. Can use alt + click to switch editor.

[EricEzaM]

Closes #39539, Closes #14862, Closes #33704

If the script editor is open, clicking on a node in the scene tree no longer switches you to the canvas item or spatial editors. The inspector is updated so you can change properties, or drag and drop the node path onto the script easily.

If you want to switch to the other editor, simply hold down the Alt key.

[groud]

In the first issue you mention, @KoBeWi talks about a can_lose_focus_on_node_selection() function. Shouldn't this simply return false ? I haven't checked the code but I guess that instead of having an hardcoded check it would be a cleaner solution no ?

[EricEzaM]

@groud can_lose_focus_on_selection() is a method in ScriptEditorBase, not on EditorPlugin, so a cast would need to be made to ScriptEditorPlugin anyway.

Also, currently there is no way to access ScriptEditorBase from a public API in ScriptEditorPlugin, so a few changes would need to be made to expose this.

[groud]

I am not really sure I understand. I might be wrong but I assumed the returned value of this function causes the script editor to loose focus, and that, maybe, it should return false instead of true (so you would have to modify it directly in script_editor_plugin.h). If this is enough to solve the problem, you won't need any cast or exposing something.

[EricEzaM]

Derp... sorry, I understand now. I didn't properly understand what you meant earlier. Yes, changing the method return to false resolves the issue in a much more simple way. Thanks.

[groud]

Derp... sorry, I understand now. I didn't properly understand what you meant earlier. Yes, changing the method return to false resolves the issue in a much more simple way. Thanks.

Oh cool. :)

Just to mention, it might be worth checking the usage of this function though. Those are all usages I see:

modules/visual_script/visual_script_editor.h:323:	virtual bool can_lose_focus_on_node_selection() override { return false; }
editor/plugins/script_editor_plugin.h:158:	virtual bool can_lose_focus_on_node_selection() { return true; }
editor/plugins/script_editor_plugin.cpp:1540:		return current->can_lose_focus_on_node_selection();
editor/plugins/text_editor.h:135:	virtual bool can_lose_focus_on_node_selection() override { return true; }

as we can see, the only place where it would return true now is going to be in text_editor.h, but I am not sure it should be kept returning true. If it should be returning false too, the can_lose_focus_on_node_selection function could be removed completely and we could make can_take_away_focus always return false.

[EricEzaM]

Yeah I did notice that. Also can_take_away_focus() also only has one call... the one right here in editor_node.cpp. It is not an API exposed to scripting so... I guess there is no harm in removing it.

[EricEzaM]

Ok, all done. Clicking node does not switch by default. User can alt + click a node to switch to the canvas item/spatial editor. This will need to be documented.

[aaronfranke]

@EricEzaM Is this still desired? If so, it needs to be rebased and tested on the latest master branch. While there are no conflicts, rebasing is important so that reviewers can easily test the PR.

[KoBeWi]

I'd remove can_take_away_focus() too. It might be "nice to have" for potential future use, but the reality is it will just end up as dead useless code (and re-adding it if necessary isn't difficult). Alternatively, you could move the KEY_ALT check to be done by this method.

btw this part of condition (ScriptEditor::get_singleton()->can_take_away_focus() || Input::get_singleton()->is_key_pressed(KEY_ALT)) doesn't need brackets.

[akien-mga]

Superseded by #61162.