Prevents incorrect connection attempt on port clicking in GraphEdit #40112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents incorrect connection attempt on port clicking in GraphEdit
|
Will review now. |
|
Blackbox testing shows that the distance drags works. Will review the code. |
fire
reviewed
Jul 4, 2020
| @@ -93,6 +93,8 @@ class GraphEdit : public Control { | |||
| String connecting_target_to; | |||
| int connecting_target_index; | |||
| bool just_disconnected; | |||
| bool connecting_valid; | |||
There was a problem hiding this comment.
In another pr initialize these variables.
fire
approved these changes
Jul 4, 2020
fire
reviewed
Jul 4, 2020
| SWAP(from_slot, to_slot); | ||
| } | ||
| emit_signal("connection_request", from, from_slot, to, to_slot); | ||
| if (connecting_valid) { |
There was a problem hiding this comment.
Instead of nesting deeper, I use continue or return. Aka return early coding. https://softwareengineering.stackexchange.com/questions/18454/should-i-return-from-a-function-early-or-use-an-if-statement
There was a problem hiding this comment.
Yeah, I know but the lines below 540 should also proceed in that if statement, so this prevents code duplication.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will prevent the new node dialog from the show if the user simply clicks on port:
Now, this dialog will show only if the user drags connection to a small distance (same for actual connection with other port):