-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TileMap to use Vector2i #39976
Conversation
70ad6db
to
7bbbc67
Compare
7bbbc67
to
11e3b8d
Compare
dd0dd07
to
6569053
Compare
6569053
to
8079f58
Compare
8079f58
to
97776b4
Compare
97776b4
to
a86239f
Compare
a86239f
to
b1a9c33
Compare
I am not sure what to do with this PR. I am rewriting the whole TileMap node, which now already uses Vector2i on my side. |
@groud There is no Vector2i in 3.x, so it's not possible to merge this in 3.2 :) The ideal thing would have been to merge this PR before you did the TileMap rewrite, this is the unfortunate reality of what happens when PRs go sitting for months and don't get reviewed. Go ahead and make whatever changes you need, once those are merged I can check if there's anything missing and if so I can rebase this PR, otherwise I'll close this PR later. |
The work done here would have been wiped out anyway, whether it would have been merged earlier or not would not have changed this.
Ok, sounds good to me. |
b1a9c33
to
0d6b16a
Compare
0d6b16a
to
90c87e8
Compare
90c87e8
to
1c94863
Compare
1c94863
to
c626962
Compare
c626962
to
ddd6fb7
Compare
24f8e99
to
1549d8d
Compare
Thanks! |
Seems to work well.