Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix window size change when restoring from minimized state #39640

Closed
wants to merge 1 commit into from

Conversation

stijn-h
Copy link
Contributor

@stijn-h stijn-h commented Jun 18, 2020

Fixes #37328

When restoring the window (editor or project manager) from a minized state, the window becomes larger. When the window is minimized, window_get_size would return the size as if the window was not minimized. This results in a miscalculation during a WM_MINMAXINFO message here:
L1827: Size2 decor = window_get_size(window_id) - window_get_real_size(window_id);

A simple solution that seems to work fine is to just remove the if statement. If this code is needed, another solution would be to skip the calculation in WM_MINMAXINFO if the window is currently minimized, but it seems like this is the only place the if branch is actually true.

@aaronfranke
Copy link
Member

@hinlopen Is this still desired? If so, it needs to be rebased and tested on the latest master branch. While there are no conflicts, rebasing is important so that reviewers can easily test the PR.

@KoBeWi
Copy link
Member

KoBeWi commented May 15, 2021

The original issue is already fixed. Thanks for the contribution nonetheless.

@KoBeWi KoBeWi closed this May 15, 2021
@stijn-h stijn-h deleted the window-restore-size branch June 2, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restoring minimized Project Manager makes it bigger
4 participants