Fix popup window size calculation in popup_centered_ratio by using Rect2 #38793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to prevent
godot/scene/main/window.cpp
Line 1007 in 163687d
Seems like a typo from 197cb4e.
Affects and fixes parts of issues like Issue1 of #37401, fixes #38726.
Completely fixes Quick Open dialogs, Orphan Resource Explorer and lots of other stuff that use popup_centered_ratio().
Note: This PR only does not fix file_dialog when the Project Manager is the main window(but that's a different issue caused by wrong parent window size being reported).