display server window position bug fix #37802
Merged
+12
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bruvzg could you have a look at this |
ThakeeNathees
force-pushed
the
window-position-bug-osx-x11
branch
from
f879c24 to
93b936f
Compare
ThakeeNathees
changed the title
bruvzg
requested changes
Apr 11, 2020
ThakeeNathees
force-pushed
the
window-position-bug-osx-x11
branch
from
93b936f to
2c27fec
Compare
ThakeeNathees
force-pushed
the
window-position-bug-osx-x11
branch
from
2c27fec to
bcc0f2c
Compare
bruvzg
reviewed
Apr 11, 2020
ThakeeNathees
force-pushed
the
window-position-bug-osx-x11
branch
from
bcc0f2c to
00b55b4
Compare
bruvzg
approved these changes
Apr 11, 2020
ThakeeNathees
force-pushed
the
window-position-bug-osx-x11
branch
3 times, most recently
from
e61f533 to
b446400
Compare
ThakeeNathees
force-pushed
the
window-position-bug-osx-x11
branch
from
b446400 to
63a00ae
Compare
ThakeeNathees
changed the title
|
@bruvzg I've also added windows(os) into this commit and it's working fine. could you review it again, and sorry for my unnecessary commits |
bruvzg
approved these changes
Apr 11, 2020
60 tasks
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #37323
#37366 is a working fix for windows but I haven't tested this pr (using windows) need testing and review (or this pr may helpful for someone trying to fix on their native)