Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename IP_Unix, IP_Address and TCP_Server to remove underscores #37700

Merged
merged 1 commit into from
May 6, 2021

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Apr 8, 2020

See #16863.

drivers/unix/ip_unix.cpp Outdated Show resolved Hide resolved
@Calinou Calinou force-pushed the rename-ip-unix-tcp-server branch from ae51562 to c20e5ea Compare April 10, 2020 10:26
@YuriSizov
Copy link
Contributor

Since renames are being merged these days, maybe worth rebasing this one? Was reminded about this horrible naming scheme and had to double check if we'd already fixed it 🙂

@Calinou Calinou force-pushed the rename-ip-unix-tcp-server branch from c20e5ea to 4edb3ed Compare May 6, 2021 00:49
@Calinou Calinou requested review from a team as code owners May 6, 2021 00:49
@Calinou Calinou changed the title Rename IP_Unix and TCP_Server to IPUnix and TCPServer Rename IP_Unix, IP_Address and TCP_Server to remove underscores May 6, 2021
@Calinou
Copy link
Member Author

Calinou commented May 6, 2021

Since renames are being merged these days, maybe worth rebasing this one? Was reminded about this horrible naming scheme and had to double check if we'd already fixed it 🙂

Rebased.

@Calinou Calinou force-pushed the rename-ip-unix-tcp-server branch from 4edb3ed to 3f078c9 Compare May 6, 2021 00:52
@Calinou Calinou requested a review from a team as a code owner May 6, 2021 00:52
@akien-mga akien-mga merged commit 42b07f7 into godotengine:master May 6, 2021
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants