Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed leak with SpecularMergeShaderRD #37584

Merged
merged 1 commit into from
Apr 4, 2020
Merged

Fixed leak with SpecularMergeShaderRD #37584

merged 1 commit into from
Apr 4, 2020

Conversation

qarmin
Copy link
Contributor

@qarmin qarmin commented Apr 4, 2020

Fixes leak

ERROR: 1 shaders of type SpecularMergeShaderRD were never freed
   at: ~ShaderRD (servers/rendering/rasterizer_rd/shader_rd.cpp:489)

I just added this line

specular_merge.shader.version_free(specular_merge.shader_version);

and sorted all others

@akien-mga akien-mga added this to the 4.0 milestone Apr 4, 2020
@akien-mga akien-mga merged commit 321ce4d into godotengine:master Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug topic:rendering
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@qarmin @akien-mga