Fix input event being dispatched multiple times on Windows #37519
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commenting that line out fixes the issue, too. I'd prefer that solution, but I don't know if it breaks anything. What is the intention? godot/platform/windows/display_server_windows.cpp Line 1846 in 058a0af |
|
Okay, I got the intention and commenting it out is not the correct solution. |
60 tasks
HaSa1002
force-pushed
the
fix-duplicate-inputs-win
branch
2 times, most recently
from
fbb9c36 to
0daf13e
Compare
|
Is this PR ready or still WIP? |
|
It's ready. |
|
This also fixes #38781 @akien-mga It would be great to merge this PR soon, as working with the editor is pretty cumbersome for Windows users at the moment. |
HaSa1002
changed the title
HaSa1002
force-pushed
the
fix-duplicate-inputs-win
branch
from
0daf13e to
e103dd0
Compare
|
Ah wait. Failed to rebase correctly. I have to check. What I removed by accident |
HaSa1002
force-pushed
the
fix-duplicate-inputs-win
branch
from
e103dd0 to
434bf05
Compare
|
Okay restored what I did... |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #37425
fixes #37322
fixes #37331
fixes #37329
fixes #38781 (as of #37519 (comment))
implemented comparable to #37339
I am a little bit unsure about this patch not only being symptom fixing. According to that call stack the recursion occurs at the window creationEdit: Fixed input deadlock