-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define a default minimum window size to workaround rendering issues #37260
Define a default minimum window size to workaround rendering issues #37260
Conversation
e507507
to
a2b69d3
Compare
Would be great to have it editable on project settings as well. |
@andreyrk I don't think this should be configurable in project settings. There are already a ton of settings, this can already be changed via script, and it's hardly a common desire to want a tiny window. |
@aaronfranke for sure it's a great thing it's a runtime option at least, it's easy to miss though and have people asking whether it's possible or not and how to do it. The desire isn't wanting a tiny window but being able to define the minimum size of it. Many games get completely broken if the user resizes it too small (issues with UI scaling for example) and one might want to tweak it to a value that works best for the game. Overall IMO it's something that fits better in the project settings, for ease of changing & no need of setting it manually in a script. |
a2b69d3
to
16e81d4
Compare
FWIW I still stand by my opinion that this should also be a project setting. Looking back, I may add that telling people to just put it in a script because one felt the settings menu was already too cluttered (which is a different issue in and out of itself) is just working against visibility of features & increasing time spent by developers on otherwise simple things. Thus, I believe #31990 deserves some more consideration |
One doesn't exclude the other 🙂 I think #31990 is good, but it needs to be rebased against the latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#31990 has been closed for a long time. Even though there is still a discussion on how to improve this further, I think that this PR is good as-is. It fixes a bug, it's a very small minimum size so it's unlikely to annoy users, and even if it does it's easy to override in script. Further improvements can be done in follow-up PRs.
The minimum window size can still be set to `Vector2(0, 0)` in a script if needed. This closes godotengine#37242.
16e81d4
to
f02a040
Compare
master
version of #51973.The minimum window size can still be set to
Vector2(0, 0)
in a script if needed.This closes #37242.