-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix C# bindings after recent breaking changes #37050
Conversation
The ideal thing would be that raising the event will also emit the signal. However, I still haven't figured out a good way to solve the problem with this circular call: |
Don't merge this yet. I forgot about clearing or possibly serializing managed callable delegates on hot-reload. |
ab456eb
to
5e674e7
Compare
This is ready now. |
@akien-mga I've updated the |
5e674e7
to
88ad362
Compare
I was waiting for the I'll do a separate PR changing the Standard and applying it to the codebase that you can rebase upon once merged, so we get the whole codebase following the new standard. |
#37106 is merged, you can rebase and drop the second commit. |
Implementation for new Variant types Callable, Signal, StringName. Added support for PackedInt64Array and PackedFloat64Array. Add generation of signal members as events, as well as support for user created signals as events. NOTE: As of now, raising such events will not emit the signal. As such, one must use `EmitSignal` instead of raising the event directly. Removed old ThreadLocal fallback class. It's safe to use thread_local now since it's supported on all minimum versions of compilers we support.
88ad362
to
6a85cdf
Compare
Implementation for new Variant types Callable, Signal, StringName.
Added support for PackedInt64Array and PackedFloat64Array.
Add generation of signal members as events, as well as support for
user created signals as events.
NOTE: As of now, raising such events will not emit the signal. As such,
one must use
EmitSignal
instead of raising the event directly.Removed old ThreadLocal fallback class. It's safe to use thread_local now since
it's supported on all minimum versions of compilers we support.