Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed default capsule axis to vertical #36488

Merged
merged 1 commit into from
Feb 23, 2020
Merged

Changed default capsule axis to vertical #36488

merged 1 commit into from
Feb 23, 2020

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented Feb 23, 2020

Changed CapsuleMesh, CapsuleShape and it's gizmos to vertical.

Closes #5813

@Chaosus Chaosus added this to the 4.0 milestone Feb 23, 2020
AndreaCatania
AndreaCatania reviewed Feb 23, 2020
View reviewed changes
Copy link
Contributor

@AndreaCatania AndreaCatania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, I've just a little comment that you can find below, but other than that this is a good change!

modules/bullet/shape_bullet.h Outdated Show resolved Hide resolved
@Calinou
Copy link
Member

Calinou commented Feb 23, 2020 •
edited
Loading

I was working on doing this, as I said on IRC this afternoon 🙁

Anyway, your PR seems fine to me.

@Chaosus
Copy link
Member Author

Chaosus commented Feb 23, 2020 •
edited
Loading

Oh, sorry about that I didnt see that. I will make you co-author..

@akien-mga akien-mga merged commit b975754 into godotengine:master Feb 23, 2020
@akien-mga
Copy link
Member

Thanks!

@Chaosus Chaosus deleted the capsule_y branch February 24, 2020 05:58
@akien-mga akien-mga mentioned this pull request Jun 19, 2020
Closed
83 tasks
@Riteo Riteo mentioned this pull request Mar 2, 2021
Merged
@AaronRecord AaronRecord mentioned this pull request Jun 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreaCatania AndreaCatania AndreaCatania approved these changes

Assignees
No one assigned
Labels
breaks compat enhancement topic:editor topic:physics
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Have Capsule Collider Vertical By Default
4 participants
@Chaosus @Calinou @akien-mga @AndreaCatania