Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix editor drawing snapping lines for wrong edge/corner when resizing elements with smart snapping enabled #35351

Merged
merged 1 commit into from
Jan 20, 2020
Merged

Fix editor drawing snapping lines for wrong edge/corner when resizing elements with smart snapping enabled #35351

merged 1 commit into from
Jan 20, 2020

Conversation

ericrybick
Copy link
Contributor

fixes #32342

@ericrybick ericrybick changed the title fix editor drawing snapping lines for wrong edge/corner when resizing elements with smart snapping enabled Fix editor drawing snapping lines for wrong edge/corner when resizing elements with smart snapping enabled Jan 20, 2020
@akien-mga akien-mga added this to the 3.2 milestone Jan 20, 2020
@akien-mga akien-mga requested a review from groud January 20, 2020 07:13
@groud
Copy link
Member

groud commented Jan 20, 2020

I don't get it. How can this have an impact ? Nothing is supposed to be modifyed by calling snap_point.

I am not sure this is the correct way to solve the problem.

@ericrybick
Copy link
Contributor Author

ericrybick commented Jan 20, 2020 •
edited
Loading

snap_transform is the transform that is used to decide where the line is drawn and snap_transform is set at the end of the snap_point() function.

snap_point():
tngzj

draw_smart_snapping():
abc

@groud
Copy link
Member

groud commented Jan 20, 2020

OK, I guess it make sense then. I would rather find a cleaner way to solve the problem, but I am not sure it is possible without a significant refactor of the code.

@akien-mga akien-mga merged commit c3fd101 into godotengine:master Jan 20, 2020
@akien-mga
Copy link
Member

Thanks!

@ericrybick ericrybick deleted the 32342-Resize-snapping-lines-bug branch January 20, 2020 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@groud groud Awaiting requested review from groud

Assignees
No one assigned
Labels
bug topic:editor
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.

Resize-snapping lines bug
3 participants
@ericrybick @groud @akien-mga