Improved TextEdit search usability & documentation #33202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Oct 31, 2019
| @@ -5443,11 +5443,11 @@ int TextEdit::_get_column_pos_of_word(const String &p_key, const String &p_searc | |||
| PoolVector<int> TextEdit::_search_bind(const String &p_key, uint32_t p_search_flags, int p_from_line, int p_from_column) const { | |||
|
|
|||
| int col, line; | |||
| if (search(p_key, p_search_flags, p_from_line, p_from_column, col, line)) { | |||
| if (search(p_key, p_search_flags, p_from_line, p_from_column, line, col)) { | |||
There was a problem hiding this comment.
This swaps line and column, was it erroneous previously?
There was a problem hiding this comment.
Yes, the arguments were previously inverted.
|
It seems a bit convoluted to have to use enum values to index a 2-value array. |
|
Ok, I was trying to keep compatibility but I don't mind changing the returned value to a dictionary. |
|
Well if this PR is actually a bugfix on the order of line/col, we can likely merge as is for 3.2, and improve the API further for 4.0 (probably as part of #31739). |
|
Sounds good! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes make
search()functionality usable in scripts by defining how to get the line and column numbers from the returnedPoolIntArray.