Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant transform method in Geometry singleton #31865

Merged
merged 1 commit into from
Sep 1, 2019
Merged

Remove redundant transform method in Geometry singleton #31865

merged 1 commit into from
Sep 1, 2019

Conversation

Xrayez
Copy link
Contributor

@Xrayez Xrayez commented Sep 1, 2019

Transform2D's xform method can be used instead which handles PoolVector2Array now (as well as 3D version), see #31761.

var trans = Transform2D(0, Vector2(100, 100))

var points = PoolVector2Array([Vector2(0, 0), Vector2(1, 0), Vector2(1, 1), Vector2(0, 1)])

points = Geometry.transform_points_2d(points, trans) # before
points = trans.xform(points) # after

Transform2D's xform method can be used instead which handles
`PoolVector2Array` now (as well as 3D version).
@Xrayez Xrayez requested a review from a team as a code owner September 1, 2019 11:40
@akien-mga akien-mga added this to the 3.2 milestone Sep 1, 2019
@akien-mga akien-mga merged commit 62c0185 into godotengine:master Sep 1, 2019
@akien-mga
Copy link
Member

Thanks!

@Xrayez Xrayez deleted the geometry-remove-transform branch September 1, 2019 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants