Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Popup::popup_centered not centralizing at the first call #30053

Merged
merged 1 commit into from
Jun 25, 2019
Merged

Fix Popup::popup_centered not centralizing at the first call #30053

merged 1 commit into from
Jun 25, 2019

Conversation

guilhermefelipecgs
Copy link
Contributor

Proper fix for #24907

@guilhermefelipecgs guilhermefelipecgs added this to the 3.2 milestone Jun 25, 2019
@guilhermefelipecgs guilhermefelipecgs force-pushed the fix_popup_centered branch 3 times, most recently from 057725a to 8ac45c5 Compare June 25, 2019 03:07
akien-mga
akien-mga reviewed Jun 25, 2019
View reviewed changes
scene/gui/popup.cpp Outdated Show resolved Hide resolved
@akien-mga akien-mga mentioned this pull request Jun 25, 2019
Closed
@guilhermefelipecgs guilhermefelipecgs force-pushed the fix_popup_centered branch 2 times, most recently from eff1c49 to 5ae2bba Compare June 25, 2019 14:52
@akien-mga akien-mga merged commit 18b62d5 into godotengine:master Jun 25, 2019
@akien-mga
Copy link
Member

Thanks!

@guilhermefelipecgs guilhermefelipecgs deleted the fix_popup_centered branch June 25, 2019 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga left review comments

Assignees
No one assigned
Labels
bug topic:core
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.
2 participants
@guilhermefelipecgs @akien-mga