Don't allow built-in scripts to use class_name #27876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That second commit is not relevant if you rebase on current master, I already committed those changes. Sounds like you're all running Arch or similar and got clang-format 8.0 landing at once @JFonS @bojidar-bg and @vnen? :) |
|
@akien-mga guilty... ✋ |
vnen
force-pushed
the
gdscript-no-builtin-name
branch
from
f91887e to
e56f5d5
Compare
|
Rebased. I guess I'm too bleeding edge with Arch. |
|
Thanks! |
|
Cherry-picked for 3.1.1. |
|
Reverted cherry-pick for now, there's a regression from this PR in #28002 which needs to be solved first. To consider again for 3.1.2. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25579