Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make brackets only be inserted when necessary when autocompleting methods #27693

Merged
merged 1 commit into from
Apr 30, 2019
Merged

Make brackets only be inserted when necessary when autocompleting methods #27693

merged 1 commit into from
Apr 30, 2019

Conversation

YeldhamDev
Copy link
Member

Before, when editing a method, autocompletion would insert brackets, regardless if there was already ones there:
example_method()()

Now, it will not insert them if brackets already exist.

@Chaosus Chaosus added this to the 3.2 milestone Apr 6, 2019
@akien-mga
Copy link
Member

Related to #23756, but not sure it fixes it.

@YeldhamDev
Copy link
Member Author

@akien-mga Nope, this is much simpler than that. It's only about not placing new brackets.

@reduz reduz requested review from Paulb23 and vnen April 21, 2019 12:31
@akien-mga akien-mga merged commit 9916319 into godotengine:master Apr 30, 2019
@akien-mga
Copy link
Member

Thanks!

@YeldhamDev YeldhamDev deleted the method_brackets_smart branch April 30, 2019 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Paulb23 Paulb23 Awaiting requested review from Paulb23

@vnen vnen Awaiting requested review from vnen

Assignees
No one assigned
Labels
enhancement topic:editor
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.
4 participants
@YeldhamDev @akien-mga @Calinou @Chaosus