Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When an animationplayer sets a property on itself recreate the caches #25547

Merged
merged 1 commit into from
Feb 1, 2019
Merged

When an animationplayer sets a property on itself recreate the caches #25547

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions scene/animation/animation_player.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,10 +344,16 @@ void AnimationPlayer::_animation_process_animation(AnimationData *p_anim, float

for (int i = 0; i < a->get_track_count(); i++) {

// If an animation changes this animation (or it animates itself)
// we need to recreate our animation cache
if (p_anim->node_cache.size() != a->get_track_count()) {
_ensure_node_caches(p_anim);
}

TrackNodeCache *nc = p_anim->node_cache[i];

if (!nc) // no node cache for this track, skip it
continue;
if (!nc)
continue; // no node cache for this track, skip it

if (!a->track_is_enabled(i))
continue; // do nothing if the track is disabled
Expand Down