Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Sequences and Spawners to Tween class #20934

Closed
wants to merge 3 commits into from

Conversation

eligt
Copy link
Contributor

@eligt eligt commented Aug 12, 2018

This allows creating very complicated tweening branching trees in a
readable way without having to manage delays manually.

Sample (functional) GDScript code looks like this:
https://github.com/eligt/godot/wiki/Tweening-sequences-and-spawners-sample-GDScript-code

Creates this resulting animation:
https://youtu.be/AVkn0ri0oHw

@eligt eligt requested a review from reduz as a code owner August 12, 2018 00:33
This allows creating very complicated tweening branching trees in a
readable way without having to manage delays manually.
@eligt eligt force-pushed the tween-sequences branch 2 times, most recently from 2e79f7f to f886ccd Compare August 12, 2018 23:21
@akien-mga akien-mga added this to the 3.1 milestone Aug 13, 2018
It makes it possible to create a delay at the very beginning of a
Sequence
@akien-mga
Copy link
Member

Moving to 3.2 milestone as we're about to enter the beta stage and release freeze for Godot 3.1. Only bug fixes against issues of the 3.1 milestone (or enhancements to core features of the 3.1 roadmap) will be considered until 3.1-stable is released.

Note: If it's merged after 3.1-stable is released, this change might be considered for cherry-picking into a later 3.1.x release.

@akien-mga akien-mga modified the milestones: 3.1, 3.2 Dec 12, 2018
@eligt
Copy link
Contributor Author

eligt commented Aug 27, 2019

I've noticed this is marked for the 3.2 milestone and I know that 3.2 is to be released relatively soon so I've updated the branch, merging it with master. I've also done a fair bit of testing (using the Tween Demo project) and everything seems to be working as expected.

@eligt eligt force-pushed the tween-sequences branch 4 times, most recently from 61dbe9c to 3f09663 Compare August 27, 2019 22:29
@akien-mga akien-mga modified the milestones: 3.2, 4.0 Oct 4, 2019
@realkotob
Copy link
Contributor

If this is still considered for 3.2 I can run some tests to see if it still runs fine on the master branch.

The changes seem pretty isolated so they shouldn't really have any weird side effects.

@lentsius-bark
Copy link
Contributor

Guess this won't make it to 3.2, hope we get a tween upgrade soon. I liked this code as the samply gdscript looks very readable.

@MarcusElg
Copy link
Contributor

@eligt There are a few conflicts rn. Mind fixing them?

@aaronfranke
Copy link
Member

@eligt Is this still desired? If so, it needs to be rebased on the latest master branch.

If not, abandoned pull requests will be closed in the future as announced here.

@aaronfranke
Copy link
Member

This PR has not received any new commits for almost a year and is abandoned, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants