Make GDScriptDepSort transitive #13414
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GDScriptDepSort now sorts using the number of steps up to the base of the inheritence tree.
|
Just tested this and while this in theory should solve the problem, I'm still getting issues and I'm actually getting null pointer errors now. |
|
Since it was tested as not fully working, and we're going into release freeze for Godot 3.0, I'll reject this PR for now. The issue is still open though and this PR can be reused as a base for a better fix for 3.1 and 3.0.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #13353 (hopefully)
GDScriptDepSort now sorts using the number of steps up to the base of the inheritance tree. This will sort the base classes before the things that inherit them which is what the original sort was wanting to do, but is also is transitive.
Testing:
This can be tested by using #13354 with the following test project: SortTest.zip. This bug being triggered does depend on the order of the scripts in the script list. I assume this order depends on the order they are loaded in so you may or may not see the bug with this test project. Incase it is difficult to reproduce with the test project I have also included a partial log of two test runs: log.txt. The bug in the log is that
node_a_51.gdis getting sorted (and reloaded) beforenode_a_41.gd, which is its base class.