-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If main_scene is not set it will be set to the current scene... #1242
Conversation
…ning the project or pressing F5
This pull request is based off of this discussion. Thanks :) |
Nice, it's a minor change but these things add up to making Godot having a better user experience. But I noticed you seem to have made another dialog to say "save the scene before running" without prompting to the "save as" window automatically. I already made this change in a commit before, so IMO you should call |
Awesome, thanks! I just added that in there instead of the message. |
As an usability feature, I'm not so sure about this one. For a new user, if this happens automatically, it may be great at first but later he or she will have no idea why a scene runs instead of another scene. In the current way, the user is forced to explore. Maybe what could happen instead is to give the option to the user to open the project manager and edit that property? As a productivity feature, I'm also not sure how useful it is as it only happens once for each project. |
why not ask a question: "Do you want to save this and make your main scene?" or maybe do what web servers do... once they see index.php they set it as the first page... in this case make main.scn/xscn/res the main scene... |
@reduz brings a good point. I think one of @mamarilmanson's suggestions would probably work better in the long run. |
Juan, I'm inclined to agree with you and the same thing had crossed my mind a while after I sent the PR. I think there are a few options here:
Regardless, unless I'm missing something, I think whatever the decision is that it probably should apply to the Export button also since it seems pointless to build out a project with no main_scene set. What do you guys think? |
I just noticed Juan already mentioned option 3, what do you guys think about option 3? And should it also apply to the "Export" button? Thanks! |
The purpose of me opening an issue about this is so we can eliminate If we add this dialog for the main scene then IMO we should save the scene |
Yeah, I definitely can understand that. However, this popup would only show up once per project and it points people (IE newcomers) to where they need to go to change the main scene, thus educating them in the process. For people working on more serious projects they will only see this popup maybe once every few months. Even if you started a new project every day, you would only see it once per day. If it stays as is in my commit, I can definitely see people who are just getting started being confused how the main scene is assigned. My main point is that this popup won't be all that intrusive. Also, unless it violates the design philosophy, maybe in the future Godot will have preferences that apply to the editor itself and not just individual projects. There the option for one or the other could exist. |
I'm going to go ahead and try out option 3 and also apply it to the Export button. |
Is it possible to get a dialog menu to change the main scene that is Opening dialog with a dropdown menu with all of the available scenes that
|
Maybe I could do something like this with the alert... "No main scene is set. What would you like to do?" There's an X on the alert for them if they just want to close it. |
I still think giving them a dropdown menu to select a main scene is more
|
If the main scene is set automatically and later on not working correctly, or if they're prevented from running their only scene because they haven't explicitly set it as the main scene... they have to go exploring either way. I would rather have it automated, myself. Why not compromise and prompt this: "No main scene set. Would you like to set this as your main scene? You can change this at any time in Project Settings." Edit: I see a couple more comments added since I had opened this tab, so this is fairly similar to Nate's idea. |
While I like the idea of a dropdown, and if I'm understanding correctly, it may be a bit overkill since most of the time the user will likely only have one scene the first time they hit F5. If the expectation was that they would have five to ten scenes at that point it would make a lot more sense. I like the idea of pointing them to "Project Settings" in some fassion or another so they know where to go to change it. I like adolson's last idea since it's clean and to the point. |
The dropdown makes sense to me because the first scene isn't always going But I read adolsons idea again and it will work well for the first run. Maybe a dropdown menu can still exist for when you change the main scene later?
|
You want a dropdown to come up every single time you run the project? |
No, just make a button to change the project's main scene in the editor's But I think adolsons solution will be best to solve this issue. I will maybe propose a shortcut to changing a main scene later in a project's development when I have time
|
Closing this. Maybe we can revisit this at a later date. :) |
If main_scene is not set it will be set to the current scene when running the project (or pressing F5)