[DOCS] TabContainer class descriptions #12055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbscribe
reviewed
Oct 12, 2017
doc/classes/TabContainer.xml
Outdated
| </description> | ||
| </method> | ||
| <method name="get_tab_align" qualifiers="const"> | ||
| <return type="int" enum="TabContainer.TabAlign"> | ||
| </return> | ||
| <description> | ||
| Return tab alignment, from the ALIGN_* enum. | ||
| Returns the tab alignment, from the ALIGN_* enum. |
There was a problem hiding this comment.
Change the , to a . and make the last sentence conform to the enum standard: See the ALIGN_* constants. (like you did below in the members description)
cbscribe
reviewed
Oct 12, 2017
doc/classes/TabContainer.xml
Outdated
| </member> | ||
| <member name="tabs_visible" type="bool" setter="set_tabs_visible" getter="are_tabs_visible"> | ||
| If [code]true[/code], all tabs that are children of the TabContainer will be visible. |
brunosxs
force-pushed
the
tabcontainer
branch
from
ed30b9c to
c297a55
Compare
|
Done. |
ghost
added
cbscribe
reviewed
Oct 13, 2017
doc/classes/TabContainer.xml
Outdated
| @@ -157,16 +160,19 @@ | |||
| <argument index="0" name="visible" type="bool"> | |||
| </argument> | |||
| <description> | |||
| Set whether the tabs should be visible or hidden. | |||
| If [code]true[/code] all the tabes will be visible. | |||
brunosxs
force-pushed
the
tabcontainer
branch
from
c297a55 to
42f576f
Compare
|
Sorry for the typo |
|
Thanks for your contribution! |
|
I am the one who has to thank you for the patience. I am learning git as I am doing things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.