More consistent script color temperatures. #11246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
|
This is probably less confusing than the current system. I like it. |
|
also gives more control to adapt the colors on light theme! |
|
@toger5 i think with this, the issue with white themes its solved (since now you cant modifiy the temperature colors anymore), unless you choose a bad accent color for white, but in that case nobody cant help you. |
|
Seemed that all the ux designy people liked it 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this makes the color temperature non configurable, so it hughlights the most used script using your defined accent color, and the cold color is the font color, so an unused script, looks the same as the rest of unused scripts (those that havent been in the temperature list).