-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make COPYRIGHT.txt
compliant with debian/copyright
specification
#101713
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
COPYRIGHT.txt
compliant with debian/copyright
specification
It's written in that file that it follows Debian's specification for machine-readable copyright information. So this PR is (probably, haven't reviewed yet) correct. |
Thank you! My bad it was right there missed it! The associated scripts in |
The changes look fine but it breaks the build, as we actually parse that file too to generate some headers, and the parser is also not spec compliant (probably doesn't need to be, but it should be adjusted to match the new format). It's in |
Would you like me to fix the parser as part of this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a small review and didn't see anything wrong. Thanks for also updating the script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Could you squash the commits? See PR workflow for instructions.
Also fix license header generation by skipping over the new Comment field in the COPYRIGHT.txt header stanza.
80fddfd
to
72856f3
Compare
Done! Thanks everyone for reviewing and again for maintaining this copyright file. |
Thanks! |
I want to note as someone helping to maintain the godot package in Debian that it's incredibly awesome and helpful that Godot maintains a Debian-compatible copyright file.
I've made some minor adjustments to conform the file to the specification.
#
comment lines into a properComment:
field../
prefixes from file paths.Files:
field specification:*
glob pattern to end of all directories, to match the files within them.Files:
field specification: