Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change print warnings to config ones for popups that need transparency #101321

Merged
merged 1 commit into from
Jan 11, 2025
Merged

Change print warnings to config ones for popups that need transparency #101321

merged 1 commit into from
Jan 11, 2025
+82 −17

Conversation

YeldhamDev
Copy link
Member

@YeldhamDev YeldhamDev added this to the 4.4 milestone Jan 8, 2025
@YeldhamDev YeldhamDev requested a review from a team as a code owner January 8, 2025 23:02
akien-mga
akien-mga reviewed Jan 8, 2025
View reviewed changes
scene/gui/popup.cpp Outdated Show resolved Hide resolved
bruvzg
bruvzg reviewed Jan 9, 2025
View reviewed changes
Copy link
Member

@bruvzg bruvzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it should use get_configuration_warnings() to show in the editor instead of printing it in runtime, it's probably better for discoverability.

@YeldhamDev YeldhamDev force-pushed the project_manager_warn_silence branch from b860bc8 to 5c63646 Compare January 9, 2025 19:01
@YeldhamDev YeldhamDev requested a review from a team as a code owner January 9, 2025 19:01
@YeldhamDev YeldhamDev changed the title Silence popup shadow warning in the project manager Change print warnings to config ones for popups that need transparency Jan 9, 2025
@YeldhamDev
Copy link
Member Author

Alright, the PR has been updated to use configuration warnings instead. They apply for PopupMenu/Panel as well as Menu/OptionButton.

@akien-mga akien-mga merged commit 33fb876 into godotengine:master Jan 11, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@YeldhamDev YeldhamDev deleted the project_manager_warn_silence branch January 14, 2025 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruvzg bruvzg bruvzg left review comments

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug enhancement regression topic:editor
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@YeldhamDev @akien-mga @bruvzg