Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure icon and splash paths on export #100920

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

Summersay415
Copy link
Contributor

Fixes #100919

@Chaosus Chaosus added this to the 4.4 milestone Dec 30, 2024
Copy link
Member

@bruvzg bruvzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested export of PCKs and ZIPs, working as expected.

@bruvzg
Copy link
Member

bruvzg commented Jan 22, 2025

Note: it seems like files were actually exported, but with uid:// prefix in the names:

PCK file listing

Screenshot 2025-01-22 104019

ZIP file listing

Screenshot 2025-01-22 105125

This is outside the scope of this PR, but we might want to add some checks (or ResourceUID::ensure_path calls) to the PCK/ZIP writing code to catch a similar issue.

@Repiteo Repiteo merged commit 1022c6b into godotengine:master Jan 22, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Jan 22, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon and splash screen raw files are not included in exported project
4 participants