[GDNative] fixed a bug with ambiguous include paths #10072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes godotengine#10071. The problem is that the json.h file includes the local variant.h instead of the "absolute" core/variant.h
|
Note that this is a "local fix". The real fix would be to use absolute include paths everywhere in the codebase, but that's a massive undertaking and the files in |
akien-mga
reviewed
Aug 4, 2017
| @@ -29,9 +29,10 @@ | |||
| /*************************************************************************/ | |||
| #include <godot/dictionary.h> | |||
|
|
|||
| #include "core/variant.h" | |||
There was a problem hiding this comment.
Would have been good to put a comment, so that we don't delete the separating line in the future, thus breaking it again next time clang-format changes the include order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #10071. The problem is that the json.h file includes the
local variant.h instead of the "absolute" core/variant.h