Don't recursively call _update_tree
#100670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a node was previously selected and the test "selected == p_node" was true the code would use set_selected() to change the selection to nullptr. However, if the tree is dirty, which is always true in this codepath, this would lead to a recursive call to _update_tree() ultimately leading to a crash due to us running out of stack. This fixes godotengine#100666
akien-mga
approved these changes
Dec 20, 2024
akien-mga
changed the title
_update_tree
|
Thanks! |
This was referenced Dec 27, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a node was previously selected and the test "selected == p_node" was true the code would use set_selected() to change the selection to nullptr. However, if the tree is dirty, which is always true in this codepath, this would lead to a recursive call to _update_tree() ultimately leading to a crash due to us running out of stack.
This fixes #100666