Improve && and & syntax highlighting by altering StringName highlighting
#100575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wierdox
changed the title
&& and & syntax highlighting by altering StringName highlighting
Mickeon
approved these changes
Dec 21, 2024
Mickeon
requested review from
HolonProduction
and removed request for
HolonProduction
AThousandShips
approved these changes
Dec 21, 2024
There was a problem hiding this comment.
The improvement is great
@dalexeev @HolonProduction do we have any testing facilities for the highlighter? If so there should probably be test cases for this, or if we are working on that functionality this should be accounted for if merged
|
Wierdox
force-pushed
the
improve_syntax_highlighting_for_shorthand_of_and_plus_bitwise_and_by_altering_string_name_highlighting
branch
from
667dc91 to
ed81a17
Compare
Repiteo
approved these changes
Dec 21, 2024
|
Thanks! |
Wierdox
deleted the
improve_syntax_highlighting_for_shorthand_of_and_plus_bitwise_and_by_altering_string_name_highlighting
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes godotengine/godot-proposals#11381
Not much to say about this PR, new code should be fairly easy to understand. Check out the proposal for an explanation and some details. That said, it could probably be cleaned up a bit, I always seem to miss something.