Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect return value on partial coverage detection. #100222

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

DarioSamo
Copy link
Contributor

Partial coverage is only supposed to be detected for draw lists but it was incorrectly being assigned to buffers.

Do test for visual regressions. This should fix the CPU bottlenecks in #100098.

Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I tested locally and this doesn't seem to break anything

@clayjohn clayjohn added this to the 4.4 milestone Dec 9, 2024
@akien-mga akien-mga added the bug label Dec 10, 2024
@Repiteo Repiteo merged commit cf038de into godotengine:master Dec 10, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Dec 10, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants