Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can apply CanvasItemMaterial to 3D Nodes #8121

Closed
27thLiz opened this issue Mar 23, 2017 · 1 comment
Closed

Can apply CanvasItemMaterial to 3D Nodes #8121

27thLiz opened this issue Mar 23, 2017 · 1 comment

Comments

@27thLiz
Copy link
Contributor

27thLiz commented Mar 23, 2017

Operating system or device - Godot version:
All - Godot master (a69e449)

Issue description:
In the inspector, for any GeometryInstance derived node, you can falsely set a CanvasItemMaterial as the material_override property. Doing so will crash the game at runtime, the editor keeps working.

Steps to reproduce:

  • Add a TestCube to a scene.
  • In the inspector, click on the Material Override property. You can choose to create a new CanvasItemMaterial
@27thLiz 27thLiz added this to the 3.0 milestone Mar 23, 2017
@akien-mga akien-mga changed the title [3.0] Can apply CanvasItemMaterial to 3D Nodes Can apply CanvasItemMaterial to 3D Nodes May 18, 2017
@27thLiz
Copy link
Contributor Author

27thLiz commented May 18, 2017

Closing, as CanvasItemMaterial has been removed by recent changes to how shaders work.
Now every Node type uses ShaderMaterial and the type is specified in the shader code.

@27thLiz 27thLiz closed this as completed May 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant