Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ColorPicker to be like Photoshop's (Can switch vertical slider / gradient bg depending on selected color component) #7366

Closed
chanon opened this issue Dec 25, 2016 · 3 comments

Comments

@chanon
Copy link
Contributor

chanon commented Dec 25, 2016

This is just a "nice to have" feature request.

The current ColorPicker is nice, but Photoshop's color picker has a few nice features I'd like to highlight.

(The following images are from Photoshop's color picker)

Here the gradient area selects Saturation and Brightness (Value) while the vertical slider selects Hue. This is similar to what Godot's ColorPicker looks like now.
Note that the vertical slider is selecting Hue because the H radio button is selected. .
image

Now maybe I like the color but want to adjust the brightness a bit so I select the B radio button to adjust the color brightness on the vertical slider. The vertical slider lets me easily pick the brightness I want. I also have a nice Hue/Saturation gradient selection area to the left.
image

I'm thinking maybe it needs more Red so I choose the R radio button to again adjust the vertical slider and see what adding more red to the color would do:
image

I find this flexibility extremely useful in helping to pick the right color.

Additionally Photoshop's color picker has the previous color (current) for easy comparison.

Of course the CMYK and Lab options aren't needed for game dev.

@ghost
Copy link

ghost commented Apr 10, 2018

Still reproducible/relevant in 3.1 master 48890b1 : the palette is in HSV only

@fire
Copy link
Member

fire commented Jan 18, 2019

2019-01-18_14-15-58

Here's an example from krita.

https://docs.krita.org/en/reference_manual/dockers/advanced_color_selector.html

My favourite model is HSY'.

@akien-mga
Copy link
Member

Feature and improvement proposals for the Godot Engine are now being discussed and reviewed in a dedicated Godot Improvement Proposals (GIP) (godotengine/godot-proposals) issue tracker. The GIP tracker has a detailed issue template designed so that proposals include all the relevant information to start a productive discussion and help the community assess the validity of the proposal for the engine.

The main (godotengine/godot) tracker is now solely dedicated to bug reports and Pull Requests, enabling contributors to have a better focus on bug fixing work. Therefore, we are now closing all older feature proposals on the main issue tracker.

If you are interested in this feature proposal, please open a new proposal on the GIP tracker following the given issue template (after checking that it doesn't exist already). Be sure to reference this closed issue if it includes any relevant discussion (which you are also encouraged to summarize in the new proposal). Thanks in advance!

Calinou added a commit to Calinou/godot that referenced this issue May 6, 2021
This only affects ColorPickerButton nodes that spawn a ColorPicker,
not standalone ColorPickers.

This partially addresses godotengine#7366.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants