-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Function texture_set_shrink_all_x2_on_set_data is missing from Godot 4 RenderingServer #67261
Comments
I believe this functionality was moved to the importer in Godot 4.0. That being said, it sounds like your game relies on having the ability to downscale all textures at run time, so an importer option may be of little help. |
If I can suggest a more elaborate feature, generally I expected to able to do something similar to how multiple resolution assets are done on iOS/Android and in frameworks like Corona/Solar2D SDK (see here for the docs and here's an example configuration). Compatibility with ninepatches included, with consistent ninepatch margins across different resolutions. They achieve this by decoupling texture pixel sizes from UI element point sizes. The "One size fits all" approach, the downsampling approach with mipmaps, and the downsampling approach with This is for a 2D UI that is intended to be visually just as crisp as the OS desktop, and it needs to be energy-efficient* and work on mediocre hardware too. (* e.g. by using Low Processor Mode) Desired project configuration:
Ideally, the developer can choose whether to supply textures in several sizes in the project, with different freely definable filename suffixes ("@1x", "@2x", "@4"), or to scale down the original size during loading, with a freely definable scale factor (not just 0.5). |
Duplicate of #43276. Please post your findings there as a comment 🙂
This was proposed in #23145 and rejected. That said, feel free to open a proposal for this on the godot-proposals repository, as the status quo may have changed since then. I personally think it's a good idea in some cases, but it may also make things more difficult to handle for beginners. Also, it should be done in a way that works with textures supplied to Control nodes as well (such as checkbox icons).
Doing this can waste a lot of file size (while also requiring manual work from the user end). I think these files should be resized on load and optionally cached instead. It takes some more time, but unless you intend to ship HD textures as a separate DLC, this on-the-fly approach can save several gigabytes in a complex 3D game. |
Godot version
4.0.beta2.mono
System information
Windows 11
Issue description
The method
void texture_set_shrink_all_x2_on_set_data ( bool shrink )
(see 3.x documentation here) is not available in Godot 4's renamed RenderingServer class.We use the method for the purpose described here:
https://docs.godotengine.org/en/stable/tutorials/rendering/multiple_resolutions.html#reducing-aliasing-on-downsampling
We decide to call or not call the
texture_set_shrink_all_x2_on_set_data
method depending on the screen resolution. For resolutions of 2880x1620 or higher, we use the original textures that are optimized for 3840x2160 and do not call that method. For lower resolutions like 1920x1080, we calltexture_set_shrink_all_x2_on_set_data
in order to reduce the required texture memory and to reduce aliasing.Available alternative: we could use mipmapping instead. However, this needlessly increases texture memory usage when the user is running a resolution like 1920x1080.
Steps to reproduce
(Using Godot 3.x)
texture_set_shrink_all_x2_on_set_data
to ready() of the main scene, in an IF statement that checks whether the screen resolution is lower than 2880x1620.Minimal reproduction project
No response
The text was updated successfully, but these errors were encountered: