-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3-to-4 project converter doesn't preserve viewport width and height #66125
Comments
Not sure, but I recall the view rect was flipped, maybe it has a clamp on negative numbers. |
This is unrelated. The issue is the project settings not being renamed when running 3to4. |
The rename aren't defined but, after few tests, it looks like no rename can be applied for a godot/editor/project_converter_3_to_4.cpp Lines 1963 to 1972 in 34e28f2
|
cc @qarmin |
In the ConfigFile format, the first subpath is the category and is not part of the line that the regex would match. Fixes godotengine#66125.
Godot version
4.0.beta1
System information
Linux (Pop!_OS 20.04)
Issue description
3-to-4 project converter changes viewport width and height. I would expect them to remain the same.
Steps to reproduce
Create a new Godot 3.x project. I used Godot 3.5.1.rc1.
Change the width and height in the project settings to 1280x720 (Project >> Project Settings... >> General >> Display >> Window >> Size >> Width,Height).
The 3.x minimal reproduction project attached below already has this change.
Import the project in Godot 4.0.beta1 and select Convert Full Project.
Go to Project >> Project Settings... >> General >> Display >> Window >> Size and enable Advanced Settings.
The Width and Height values are preserved, but the Viewport Width and Viewport Height have different values: 1152 and 648, respectively.
Minimal reproduction project
project_converter_3_to_4-bug3.zip
The text was updated successfully, but these errors were encountered: