Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor Shortcut sections re-order based on which shortcuts have been overridden #65956

Closed
EricEzaM opened this issue Sep 17, 2022 · 0 comments · Fixed by #65957
Closed

Editor Shortcut sections re-order based on which shortcuts have been overridden #65956

EricEzaM opened this issue Sep 17, 2022 · 0 comments · Fixed by #65957
Assignees
@EricEzaM
Labels
bug topic:editor
Milestone
4.0

Comments

@EricEzaM
Copy link
Contributor

Godot version

4.0 57bdddc

System information

WIN 10

Issue description

When you override editor shortcuts, the order in which the sections appear changes. I found this out while looking at #58585, where I found that when the shortcut was added at runtime -> went to bottom of list. However when shortcut was already existing and loaded from editor settings -> went to top of list. This is problematic if we do want plugins to register shortcuts.

Steps to reproduce

  • Have NO shortcuts overridden, i.e. in editor_settings.tres -> shortcuts = [] (or not there at all)
  • Observe default sections order:
    image
  • Override shortcut (I chose layout/save_layout)
  • Restart editor
  • Observe section order:
    image
  • Note layout is now at the top.
  • Override shortcut again (e.g. file_dialog/go_back)
    image
  • Note order of sections.

Minimal reproduction project

No response
@EricEzaM EricEzaM self-assigned this Sep 17, 2022
@EricEzaM EricEzaM added this to the 4.0 milestone Sep 17, 2022
@EricEzaM EricEzaM mentioned this issue Sep 17, 2022
Merged
@YuriSizov YuriSizov changed the title Editor Shortcut sections re-order based on which shortcuts have been overriden. Editor Shortcut sections re-order based on which shortcuts have been overridden. Sep 17, 2022
@YuriSizov YuriSizov changed the title Editor Shortcut sections re-order based on which shortcuts have been overridden. Editor Shortcut sections re-order based on which shortcuts have been overridden Sep 17, 2022
akien-mga added a commit that referenced this issue Sep 20, 2022
@akien-mga
Merge pull request #65957 from EricEzaM/GH-65956-fix-ed-shortcut-sect…
1a0943e 
…ion-order

Update Editor Shortcuts tree creation to always have sections in same order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EricEzaM EricEzaM

Labels
bug topic:editor
Projects
None yet
Milestone
4.0
Development

Successfully merging a pull request may close this issue.

Update Editor Shortcuts tree creation to always have sections in same order EricEzaM/godot
1 participant
@EricEzaM