Godot 4: a click on an animation name can paste name of animation previously renamed on SpriteFrames

[gustavi]

Godot version

v4.0.dev.calinou [4f29823]

System information

Windows 10 64bit - Vulkan API 1.2.141 - GeForce GTX 1660 SUPER

Issue description

A video is better than words:

2021-12-09.21-58-46.mp4

Note: I only use mouse to perform this bug (I'm not pasting anything with my keyboard).

Godot 3.4 and 3.4.1-rc2 are not affected by this bug. All official builds are affected.

Steps to reproduce

1. Go to SpriteFrames menu
2. Create an animation named "a"
3. Create an animation named "b"
4. Double click on "a" for editing the name
5. Click on "b"
6. "b" should be renamed "a 1"

Minimal reproduction project

bug-click-animation-name.zip

[jmb462]

The bug concerns Tree node itself (not only SpriteFrames)

While renaming, when clicking on another item popup_edited_item is updated before the rename is validated.

[KoBeWi]

Looks like #42419, except the "tree" in SpriteFrames editor is an ItemList.

[Rindbee]

I think I already know about the cause of this problem.
The reason is similar to #60842 (comment)

I added a print code to TreeItem::set_text and the log is as follows:

godot/editor/plugins/sprite_frames_editor_plugin.cpp

Line 894 in 296c8b7

void SpriteFramesEditor::_update_library(bool p_skip_selector) {

In this method, the entire tree is rebuilt. And this method may be called for a small change.

[anvilfolk]

Cannot reproduce on master. Seems like it was fixed by whatever fixed #42419?

2022-11-15.15-22-17.mp4

[akien-mga]

Thanks for testing! Closing.

[Rindbee]

Sorry, this issue doesn't seem to be resolved yet in cfb9cae.

0.mp4

[anvilfolk]

I'm recompiling right now to test again, but it looks like you may have double-click selected the name and dragged it onto the other animation name?

[anvilfolk]

Ok, here are some more details.

If you select a node, enter rename mode, then click some other node after a bit of time has passed, the bug does not occur.

If you double-click a node and immediately after click another node, the second node will become "selected". You can see it because it becomes highlighted. In that situation, clicking again anywhere will rename the last node selected.

It will look like this: original renamed node is selected and in focus. Second clicked element is selected and not in focus.

Also, @marzecdawid was working on some Tree stuff, so thought I'd give him a tag :)

[Rindbee]

It seems that the results returned by Tree::get_edited() and Tree::get_selected() are inconsistent.

Edit:

godot/editor/plugins/sprite_frames_editor_plugin.cpp

Lines 680 to 682 in cca9f78

	TreeItem *selected = animations->get_selected();
	ERR_FAIL_COND(!selected);
	edited_anim = selected->get_text(0);

godot/editor/plugins/sprite_frames_editor_plugin.cpp

Lines 723 to 732 in cca9f78

	TreeItem *edited = animations->get_edited();
	if (!edited) {
	return;
	}
	String new_name = edited->get_text(0);
	if (new_name == String(edited_anim)) {
	return;
	}

The comparison here is the text in edited and selected, so it should be required that edited and selected are the same.